[Bug fix] Fix typos, static methods and other sanity improvements in the package (#1129)

2024-01-08 19:47:46 +01:00
parent 62c0c52e31
commit 2496ed133e
41 changed files with 133 additions and 103 deletions
--- a/embedchain/llm/google.py
+++ b/embedchain/llm/google.py
@@ -44,7 +44,7 @@ class GoogleLlm(BaseLlm):
            "temperature": self.config.temperature or 0.5,
        }

-        if self.config.top_p >= 0.0 and self.config.top_p <= 1.0:
+        if 0.0 <= self.config.top_p <= 1.0:
            generation_config_params["top_p"] = self.config.top_p
        else:
            raise ValueError("`top_p` must be > 0.0 and < 1.0")