14893e62a5
This MVP release provides a complete full-stack solution for managing action mappings in Geutebruck's GeViScope and GeViSoft video surveillance systems. ## Features ### Flutter Web Application (Port 8081) - Modern, responsive UI for managing action mappings - Action picker dialog with full parameter configuration - Support for both GSC (GeViScope) and G-Core server actions - Consistent UI for input and output actions with edit/delete capabilities - Real-time action mapping creation, editing, and deletion - Server categorization (GSC: prefix for GeViScope, G-Core: prefix for G-Core servers) ### FastAPI REST Backend (Port 8000) - RESTful API for action mapping CRUD operations - Action template service with comprehensive action catalog (247 actions) - Server management (G-Core and GeViScope servers) - Configuration tree reading and writing - JWT authentication with role-based access control - PostgreSQL database integration ### C# SDK Bridge (gRPC, Port 50051) - Native integration with GeViSoft SDK (GeViProcAPINET_4_0.dll) - Action mapping creation with correct binary format - Support for GSC and G-Core action types - Proper Camera parameter inclusion in action strings (fixes CrossSwitch bug) - Action ID lookup table with server-specific action IDs - Configuration reading/writing via SetupClient ## Bug Fixes - **CrossSwitch Bug**: GSC and G-Core actions now correctly display camera/PTZ head parameters in GeViSet - Action strings now include Camera parameter: `@ PanLeft (Comment: "", Camera: 101028)` - Proper filter flags and VideoInput=0 for action mappings - Correct action ID assignment (4198 for GSC, 9294 for G-Core PanLeft) ## Technical Stack - **Frontend**: Flutter Web, Dart, Dio HTTP client - **Backend**: Python FastAPI, PostgreSQL, Redis - **SDK Bridge**: C# .NET 8.0, gRPC, GeViSoft SDK - **Authentication**: JWT tokens - **Configuration**: GeViSoft .set files (binary format) ## Credentials - GeViSoft/GeViScope: username=sysadmin, password=masterkey - Default admin: username=admin, password=admin123 ## Deployment All services run on localhost: - Flutter Web: http://localhost:8081 - FastAPI: http://localhost:8000 - SDK Bridge gRPC: localhost:50051 - GeViServer: localhost (default port) Generated with Claude Code (https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
78 lines
2.5 KiB
Markdown
78 lines
2.5 KiB
Markdown
# CRITICAL BUG FIX - DeleteActionMapping Cascade Deletion
|
|
|
|
## Date: 2025-12-16
|
|
|
|
## Severity: CRITICAL - Data Loss
|
|
|
|
## Summary
|
|
DeleteActionMapping operation caused cascade deletion of ~54 action mappings during testing, reducing total from ~60 to only 6 mappings.
|
|
|
|
## Root Cause
|
|
When deleting multiple action mappings, IDs shift after each deletion. Deleting in ascending order causes wrong mappings to be deleted.
|
|
|
|
### Example of the Bug:
|
|
```
|
|
Original mappings: #1, #2, #3, #4, #5
|
|
Want to delete: #3, #4, #5
|
|
|
|
Delete #3 → Mappings become: #1, #2, #3(was 4), #4(was 5)
|
|
Delete #4 → Deletes what was originally #5! ✗
|
|
Delete #5 → Deletes wrong mapping! ✗
|
|
```
|
|
|
|
## The Fix
|
|
|
|
**Always delete in REVERSE order (highest ID first):**
|
|
|
|
### WRONG (causes cascade deletion):
|
|
```python
|
|
for mapping in mappings_to_delete:
|
|
delete_action_mapping(mapping['id']) # ✗ WRONG
|
|
```
|
|
|
|
### CORRECT:
|
|
```python
|
|
# Sort by ID descending
|
|
sorted_mappings = sorted(mappings_to_delete, key=lambda x: x['id'], reverse=True)
|
|
|
|
for mapping in sorted_mappings:
|
|
delete_action_mapping(mapping['id']) # ✓ CORRECT
|
|
```
|
|
|
|
## Files Fixed
|
|
- `comprehensive_crud_test.py` - Lines 436-449
|
|
- Added reverse sorting before deletion loop
|
|
- Added comment explaining why reverse order is critical
|
|
|
|
## Testing Required
|
|
Before using DeleteActionMapping in production:
|
|
|
|
1. ✅ Restore configuration from backup (TestMKS_original.set)
|
|
2. ✅ Test delete operation with fixed code
|
|
3. ✅ Verify only intended mappings are deleted
|
|
4. ✅ Verify count before/after matches expected delta
|
|
|
|
## Impact Assessment
|
|
- **Affected Environment**: Development/Test only
|
|
- **Production Impact**: NONE (bug caught before production deployment)
|
|
- **Data Loss**: ~54 test action mappings (recoverable from backup)
|
|
|
|
## Prevention Measures
|
|
1. **Code Review**: All delete-by-index operations must be reviewed
|
|
2. **Testing**: Always verify delete operations with read-after-delete
|
|
3. **Documentation**: Add warning comment to DeleteActionMapping implementation
|
|
4. **Safe Delete**: Consider adding bulk delete method that handles ordering automatically
|
|
|
|
## Related Code
|
|
- SDK Bridge: `ConfigurationServiceImplementation.cs` - DeleteActionMapping method
|
|
- Python Test: `comprehensive_crud_test.py` - Lines 436-449
|
|
- Server Manager: `server_manager.py` - delete_action_mapping function
|
|
|
|
## Status
|
|
- [x] Bug identified
|
|
- [x] Root cause analyzed
|
|
- [x] Fix implemented in test code
|
|
- [ ] SDK Bridge bulk delete helper (future enhancement)
|
|
- [ ] Test with restored configuration
|
|
- [ ] Verify fix works correctly
|