Formatting (#2750)
This commit is contained in:
@@ -10,18 +10,19 @@ def _setup_mocks(mocker):
|
||||
"""Helper to setup common mocks for both sync and async fixtures"""
|
||||
mock_embedder = mocker.MagicMock()
|
||||
mock_embedder.return_value.embed.return_value = [0.1, 0.2, 0.3]
|
||||
mocker.patch('mem0.utils.factory.EmbedderFactory.create', mock_embedder)
|
||||
|
||||
mocker.patch("mem0.utils.factory.EmbedderFactory.create", mock_embedder)
|
||||
|
||||
mock_vector_store = mocker.MagicMock()
|
||||
mock_vector_store.return_value.search.return_value = []
|
||||
mocker.patch('mem0.utils.factory.VectorStoreFactory.create',
|
||||
side_effect=[mock_vector_store.return_value, mocker.MagicMock()])
|
||||
|
||||
mocker.patch(
|
||||
"mem0.utils.factory.VectorStoreFactory.create", side_effect=[mock_vector_store.return_value, mocker.MagicMock()]
|
||||
)
|
||||
|
||||
mock_llm = mocker.MagicMock()
|
||||
mocker.patch('mem0.utils.factory.LlmFactory.create', mock_llm)
|
||||
|
||||
mocker.patch('mem0.memory.storage.SQLiteManager', mocker.MagicMock())
|
||||
|
||||
mocker.patch("mem0.utils.factory.LlmFactory.create", mock_llm)
|
||||
|
||||
mocker.patch("mem0.memory.storage.SQLiteManager", mocker.MagicMock())
|
||||
|
||||
return mock_llm, mock_vector_store
|
||||
|
||||
|
||||
@@ -30,29 +31,26 @@ class TestAddToVectorStoreErrors:
|
||||
def mock_memory(self, mocker):
|
||||
"""Fixture that returns a Memory instance with mocker-based mocks"""
|
||||
mock_llm, _ = _setup_mocks(mocker)
|
||||
|
||||
|
||||
memory = Memory()
|
||||
memory.config = mocker.MagicMock()
|
||||
memory.config.custom_fact_extraction_prompt = None
|
||||
memory.config.custom_update_memory_prompt = None
|
||||
memory.api_version = "v1.1"
|
||||
|
||||
|
||||
return memory
|
||||
|
||||
def test_empty_llm_response_fact_extraction(self, mock_memory, caplog):
|
||||
"""Test empty response from LLM during fact extraction"""
|
||||
# Setup
|
||||
mock_memory.llm.generate_response.return_value = ""
|
||||
|
||||
|
||||
# Execute
|
||||
with caplog.at_level(logging.ERROR):
|
||||
result = mock_memory._add_to_vector_store(
|
||||
messages=[{"role": "user", "content": "test"}],
|
||||
metadata={},
|
||||
filters={},
|
||||
infer=True
|
||||
messages=[{"role": "user", "content": "test"}], metadata={}, filters={}, infer=True
|
||||
)
|
||||
|
||||
|
||||
# Verify
|
||||
assert mock_memory.llm.generate_response.call_count == 2
|
||||
assert result == [] # Should return empty list when no memories processed
|
||||
@@ -62,20 +60,14 @@ class TestAddToVectorStoreErrors:
|
||||
"""Test empty response from LLM during memory actions"""
|
||||
# Setup
|
||||
# First call returns valid JSON, second call returns empty string
|
||||
mock_memory.llm.generate_response.side_effect = [
|
||||
'{"facts": ["test fact"]}',
|
||||
""
|
||||
]
|
||||
|
||||
mock_memory.llm.generate_response.side_effect = ['{"facts": ["test fact"]}', ""]
|
||||
|
||||
# Execute
|
||||
with caplog.at_level(logging.ERROR):
|
||||
result = mock_memory._add_to_vector_store(
|
||||
messages=[{"role": "user", "content": "test"}],
|
||||
metadata={},
|
||||
filters={},
|
||||
infer=True
|
||||
messages=[{"role": "user", "content": "test"}], metadata={}, filters={}, infer=True
|
||||
)
|
||||
|
||||
|
||||
# Verify
|
||||
assert mock_memory.llm.generate_response.call_count == 2
|
||||
assert result == [] # Should return empty list when no memories processed
|
||||
@@ -88,48 +80,39 @@ class TestAsyncAddToVectorStoreErrors:
|
||||
def mock_async_memory(self, mocker):
|
||||
"""Fixture for AsyncMemory with mocker-based mocks"""
|
||||
mock_llm, _ = _setup_mocks(mocker)
|
||||
|
||||
|
||||
memory = AsyncMemory()
|
||||
memory.config = mocker.MagicMock()
|
||||
memory.config.custom_fact_extraction_prompt = None
|
||||
memory.config.custom_update_memory_prompt = None
|
||||
memory.api_version = "v1.1"
|
||||
|
||||
|
||||
return memory
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_async_empty_llm_response_fact_extraction(self, mock_async_memory, caplog, mocker):
|
||||
"""Test empty response in AsyncMemory._add_to_vector_store"""
|
||||
mocker.patch('mem0.utils.factory.EmbedderFactory.create', return_value=MagicMock())
|
||||
mocker.patch("mem0.utils.factory.EmbedderFactory.create", return_value=MagicMock())
|
||||
mock_async_memory.llm.generate_response.return_value = ""
|
||||
|
||||
|
||||
with caplog.at_level(logging.ERROR):
|
||||
result = await mock_async_memory._add_to_vector_store(
|
||||
messages=[{"role": "user", "content": "test"}],
|
||||
metadata={},
|
||||
filters={},
|
||||
infer=True
|
||||
messages=[{"role": "user", "content": "test"}], metadata={}, filters={}, infer=True
|
||||
)
|
||||
|
||||
|
||||
assert result == []
|
||||
assert "Error in new_retrieved_facts" in caplog.text
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_async_empty_llm_response_memory_actions(self, mock_async_memory, caplog, mocker):
|
||||
"""Test empty response in AsyncMemory._add_to_vector_store"""
|
||||
mocker.patch('mem0.utils.factory.EmbedderFactory.create', return_value=MagicMock())
|
||||
mock_async_memory.llm.generate_response.side_effect = [
|
||||
'{"facts": ["test fact"]}',
|
||||
""
|
||||
]
|
||||
|
||||
mocker.patch("mem0.utils.factory.EmbedderFactory.create", return_value=MagicMock())
|
||||
mock_async_memory.llm.generate_response.side_effect = ['{"facts": ["test fact"]}', ""]
|
||||
|
||||
with caplog.at_level(logging.ERROR):
|
||||
result = await mock_async_memory._add_to_vector_store(
|
||||
messages=[{"role": "user", "content": "test"}],
|
||||
metadata={},
|
||||
filters={},
|
||||
infer=True
|
||||
messages=[{"role": "user", "content": "test"}], metadata={}, filters={}, infer=True
|
||||
)
|
||||
|
||||
|
||||
assert result == []
|
||||
assert "Invalid JSON response" in caplog.text
|
||||
|
||||
Reference in New Issue
Block a user