From 9a116830039e0cdd1cc88dbdcd10e241ee89ed4e Mon Sep 17 00:00:00 2001 From: Saurabh Misra Date: Thu, 15 Feb 2024 23:18:53 -0800 Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=EF=B8=8F=20Speed=20up=20`is=5Freadabl?= =?UTF-8?q?e=20by`=20101%=20in=20`embedchain/utils/misc.py`=20(#1258)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com> --- embedchain/utils/misc.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/embedchain/utils/misc.py b/embedchain/utils/misc.py index cb7ff090..1c2a12a1 100644 --- a/embedchain/utils/misc.py +++ b/embedchain/utils/misc.py @@ -109,11 +109,11 @@ def is_readable(s): :param s: string :return: True if the string is more than 95% printable. """ - try: - printable_ratio = sum(c in string.printable for c in s) / len(s) - except ZeroDivisionError: - logging.warning("Empty string processed as unreadable") - printable_ratio = 0 + len_s = len(s) + if len_s == 0: + return False + printable_chars = set(string.printable) + printable_ratio = sum(c in printable_chars for c in s) / len_s return printable_ratio > 0.95 # 95% of characters are printable