fix(OMM): Memories not appearing in MCP clients added from Dashboard (#2704)

Co-authored-by: Deshraj Yadav <deshraj@gatech.edu>

openmemory/api/app/routers/memories.py

@@ -1,12 +1,14 @@
 from datetime import datetime, UTC
 from typing import List, Optional, Set
-from uuid import UUID
+from uuid import UUID, uuid4
+import logging
 from fastapi import APIRouter, Depends, HTTPException, Query
 from sqlalchemy.orm import Session, joinedload
 from fastapi_pagination import Page, Params
 from fastapi_pagination.ext.sqlalchemy import paginate as sqlalchemy_paginate
 from pydantic import BaseModel
 from sqlalchemy import or_, func
+from app.utils.memory import get_memory_client
 
 from app.database import get_db
 from app.models import (
@@ -16,6 +18,8 @@ from app.models import (
 from app.schemas import MemoryResponse, PaginatedMemoryResponse
 from app.utils.permissions import check_memory_access_permissions
 
+memory_client = get_memory_client()
+
 router = APIRouter(prefix="/api/v1/memories", tags=["memories"])
 
 
@@ -220,16 +224,102 @@ async def create_memory(
     if not app_obj.is_active:
         raise HTTPException(status_code=403, detail=f"App {request.app} is currently paused on OpenMemory. Cannot create new memories.")
 
-    # Create memory
+    # Log what we're about to do
+    logging.info(f"Creating memory for user_id: {request.user_id} with app: {request.app}")
+    
+    # Save to Qdrant via memory_client
+    qdrant_response = memory_client.add(
+        request.text,
+        user_id=request.user_id,  # Use string user_id to match search
+        metadata={
+            "source_app": "openmemory",
+            "mcp_client": request.app,
+        }
+    )
+    
+    # Log the response for debugging
+    logging.info(f"Qdrant response: {qdrant_response}")
+    
+    # Process Qdrant response
+    if isinstance(qdrant_response, dict) and 'results' in qdrant_response:
+        for result in qdrant_response['results']:
+            if result['event'] == 'ADD':
+                # Get the Qdrant-generated ID
+                memory_id = UUID(result['id'])
+                
+                # Check if memory already exists
+                existing_memory = db.query(Memory).filter(Memory.id == memory_id).first()
+                
+                if existing_memory:
+                    # Update existing memory
+                    existing_memory.state = MemoryState.active
+                    existing_memory.content = result['memory']
+                    memory = existing_memory
+                else:
+                    # Create memory with the EXACT SAME ID from Qdrant
+                    memory = Memory(
+                        id=memory_id,  # Use the same ID that Qdrant generated
+                        user_id=user.id,
+                        app_id=app_obj.id,
+                        content=result['memory'],
+                        metadata_=request.metadata,
+                        state=MemoryState.active
+                    )
+                    db.add(memory)
+                
+                # Create history entry
+                history = MemoryStatusHistory(
+                    memory_id=memory_id,
+                    changed_by=user.id,
+                    old_state=MemoryState.deleted if existing_memory else MemoryState.deleted,
+                    new_state=MemoryState.active
+                )
+                db.add(history)
+                
+                db.commit()
+                db.refresh(memory)
+                return memory
+    
+    # Fallback to traditional DB-only approach if Qdrant integration fails
+    # Generate a random UUID for the memory
+    memory_id = uuid4()
     memory = Memory(
+        id=memory_id,
         user_id=user.id,
         app_id=app_obj.id,
         content=request.text,
         metadata_=request.metadata
     )
     db.add(memory)
+    
+    # Create history entry
+    history = MemoryStatusHistory(
+        memory_id=memory_id,
+        changed_by=user.id,
+        old_state=MemoryState.deleted,
+        new_state=MemoryState.active
+    )
+    db.add(history)
+    
     db.commit()
     db.refresh(memory)
+    
+    # Attempt to add to Qdrant with the same ID we just created
+    try:
+        # Try to add with our specific ID
+        memory_client.add(
+            request.text,
+            memory_id=str(memory_id),  # Specify the ID
+            user_id=request.user_id,
+            metadata={
+                "source_app": "openmemory",
+                "mcp_client": request.app,
+            }
+        )
+    except Exception as e:
+        logging.error(f"Failed to add to Qdrant in fallback path: {e}")
+        # Continue anyway, the DB record is created
+    
     return memory
 
 
@@ -572,4 +662,4 @@ async def get_related_memories(
             )
             for memory in items
         ]
-    )
+    )