refactor: classes and configs (#528)

tests/vectordb/test_elasticsearch_db.py

@@ -1,7 +1,7 @@
 import unittest
-from unittest.mock import Mock
 
 from embedchain.config import ElasticsearchDBConfig
+from embedchain.embedder.base_embedder import BaseEmbedder
 from embedchain.vectordb.elasticsearch_db import ElasticsearchDB
 
 
@@ -10,24 +10,20 @@ class TestEsDB(unittest.TestCase):
         self.es_config = ElasticsearchDBConfig()
         self.vector_dim = 384
 
-    def test_init_with_invalid_embedding_fn(self):
-        # Test if an exception is raised when an invalid embedding_fn is provided
-        with self.assertRaises(ValueError):
-            ElasticsearchDB(embedding_fn=None)
-
     def test_init_with_invalid_es_config(self):
         # Test if an exception is raised when an invalid es_config is provided
         with self.assertRaises(ValueError):
-            ElasticsearchDB(embedding_fn=Mock(), es_config=None)
+            ElasticsearchDB(es_config=None)
 
     def test_init_with_invalid_vector_dim(self):
         # Test if an exception is raised when an invalid vector_dim is provided
+        embedder = BaseEmbedder()
+        embedder.set_vector_dimension(None)
         with self.assertRaises(ValueError):
-            ElasticsearchDB(embedding_fn=Mock(), es_config=self.es_config, vector_dim=None)
+            ElasticsearchDB(es_config=self.es_config)
 
     def test_init_with_invalid_collection_name(self):
         # Test if an exception is raised when an invalid collection_name is provided
+        self.es_config.collection_name = None
         with self.assertRaises(ValueError):
-            ElasticsearchDB(
-                embedding_fn=Mock(), es_config=self.es_config, vector_dim=self.vector_dim, collection_name=None
-            )
+            ElasticsearchDB(es_config=self.es_config)