From 2aa25a5169dd289fbcd7d0756ee52168afe8a859 Mon Sep 17 00:00:00 2001
From: Qihang <35721413+Mark-Zeng@users.noreply.github.com>
Date: Sun, 3 Sep 2023 12:41:09 -0700
Subject: [PATCH] Bump up LangChain version and bugfix (#536)

Co-authored-by: Taranjeet Singh <reachtotj@gmail.com>
---
 embedchain/vectordb/chroma_db.py |  2 +-
 pyproject.toml                   |  2 +-
 tests/vectordb/test_chroma_db.py | 17 +++++------------
 3 files changed, 7 insertions(+), 14 deletions(-)

diff --git a/embedchain/vectordb/chroma_db.py b/embedchain/vectordb/chroma_db.py
index d9609e33..715721d0 100644
--- a/embedchain/vectordb/chroma_db.py
+++ b/embedchain/vectordb/chroma_db.py
@@ -28,7 +28,7 @@ class ChromaDB(BaseVectorDB):
 
         if host and port:
             logging.info(f"Connecting to ChromaDB server: {host}:{port}")
-            self.client = chromadb.HttpClient(host=host, port=8000)
+            self.client = chromadb.HttpClient(host=host, port=port)
         else:
             if db_dir is None:
                 db_dir = "db"
diff --git a/pyproject.toml b/pyproject.toml
index 69aedddd..1d85c375 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -82,7 +82,7 @@ color = true
 [tool.poetry.dependencies]
 python = ">=3.9,<3.9.7 || >3.9.7,<4.0"
 python-dotenv = "^1.0.0"
-langchain = "^0.0.237"
+langchain = "^0.0.279"
 requests = "^2.31.0"
 openai = "^0.27.5"
 tiktoken = "^0.4.0"
diff --git a/tests/vectordb/test_chroma_db.py b/tests/vectordb/test_chroma_db.py
index bb14ef6b..77431576 100644
--- a/tests/vectordb/test_chroma_db.py
+++ b/tests/vectordb/test_chroma_db.py
@@ -3,11 +3,9 @@
 import unittest
 from unittest.mock import patch
 
-from chromadb.config import Settings
-
 from embedchain import App
 from embedchain.config import AppConfig
-from embedchain.vectordb.chroma_db import ChromaDB, chromadb
+from embedchain.vectordb.chroma_db import ChromaDB
 
 
 class TestChromaDbHosts(unittest.TestCase):
@@ -18,15 +16,10 @@ class TestChromaDbHosts(unittest.TestCase):
         host = "test-host"
         port = "1234"
 
-        with patch.object(chromadb, "HttpClient") as mock_client:
-            _db = ChromaDB(host=host, port=port, embedding_fn=len)
-
-        expected_settings = Settings(
-            chroma_server_host="test-host",
-            chroma_server_http_port="1234",
-        )
-
-        mock_client.assert_called_once_with(expected_settings)
+        db = ChromaDB(host=host, port=port, embedding_fn=len)
+        settings = db.client.get_settings()
+        self.assertEqual(settings.chroma_server_host, host)
+        self.assertEqual(settings.chroma_server_http_port, port)
 
 
 # Review this test