Handle empty field in new_memories_with_actions (#2330)
This commit is contained in:
@@ -215,42 +215,45 @@ class Memory(MemoryBase):
|
|||||||
for resp in new_memories_with_actions.get("memory", []):
|
for resp in new_memories_with_actions.get("memory", []):
|
||||||
logging.info(resp)
|
logging.info(resp)
|
||||||
try:
|
try:
|
||||||
if resp.get("event", "") == "ADD":
|
if not resp.get("text"):
|
||||||
|
logging.info("Skipping memory entry because of empty `text` field.")
|
||||||
|
continue
|
||||||
|
elif resp.get("event") == "ADD":
|
||||||
memory_id = self._create_memory(
|
memory_id = self._create_memory(
|
||||||
data=resp.get("text", ""), existing_embeddings=new_message_embeddings, metadata=metadata
|
data=resp.get("text"), existing_embeddings=new_message_embeddings, metadata=metadata
|
||||||
)
|
)
|
||||||
returned_memories.append(
|
returned_memories.append(
|
||||||
{
|
{
|
||||||
"id": memory_id,
|
"id": memory_id,
|
||||||
"memory": resp.get("text", ""),
|
"memory": resp.get("text"),
|
||||||
"event": resp.get("event", ""),
|
"event": resp.get("event"),
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
elif resp.get("event", "") == "UPDATE":
|
elif resp.get("event") == "UPDATE":
|
||||||
self._update_memory(
|
self._update_memory(
|
||||||
memory_id=temp_uuid_mapping[resp["id"]],
|
memory_id=temp_uuid_mapping[resp["id"]],
|
||||||
data=resp.get("text", ""),
|
data=resp.get("text"),
|
||||||
existing_embeddings=new_message_embeddings,
|
existing_embeddings=new_message_embeddings,
|
||||||
metadata=metadata,
|
metadata=metadata,
|
||||||
)
|
)
|
||||||
returned_memories.append(
|
returned_memories.append(
|
||||||
{
|
{
|
||||||
"id": temp_uuid_mapping[resp.get("id", "")],
|
"id": temp_uuid_mapping[resp.get("id")],
|
||||||
"memory": resp.get("text", ""),
|
"memory": resp.get("text"),
|
||||||
"event": resp.get("event", ""),
|
"event": resp.get("event"),
|
||||||
"previous_memory": resp.get("old_memory", ""),
|
"previous_memory": resp.get("old_memory"),
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
elif resp.get("event", "") == "DELETE":
|
elif resp.get("event") == "DELETE":
|
||||||
self._delete_memory(memory_id=temp_uuid_mapping[resp.get("id", "")])
|
self._delete_memory(memory_id=temp_uuid_mapping[resp.get("id")])
|
||||||
returned_memories.append(
|
returned_memories.append(
|
||||||
{
|
{
|
||||||
"id": temp_uuid_mapping[resp.get("id", "")],
|
"id": temp_uuid_mapping[resp.get("id")],
|
||||||
"memory": resp.get("text", ""),
|
"memory": resp.get("text"),
|
||||||
"event": resp.get("event", ""),
|
"event": resp.get("event"),
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
elif resp.get("event", "") == "NONE":
|
elif resp.get("event") == "NONE":
|
||||||
logging.info("NOOP for Memory.")
|
logging.info("NOOP for Memory.")
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
logging.error(f"Error in new_memories_with_actions: {e}")
|
logging.error(f"Error in new_memories_with_actions: {e}")
|
||||||
|
|||||||
Reference in New Issue
Block a user