fix: elastic search (#600)

tests/embedder/test_embedder.py

@@ -0,0 +1,11 @@
+import unittest
+
+from embedchain.embedder.base import BaseEmbedder
+
+
+class TestEmbedder(unittest.TestCase):
+    def test_init_with_invalid_vector_dim(self):
+        # Test if an exception is raised when an invalid vector_dim is provided
+        embedder = BaseEmbedder()
+        with self.assertRaises(TypeError):
+            embedder.set_vector_dimension(None)

tests/vectordb/test_elasticsearch_db.py

@@ -1,29 +1,26 @@
+import os
 import unittest
 
 from embedchain.config import ElasticsearchDBConfig
-from embedchain.embedder.base import BaseEmbedder
 from embedchain.vectordb.elasticsearch import ElasticsearchDB
 
 
 class TestEsDB(unittest.TestCase):
     def setUp(self):
-        self.es_config = ElasticsearchDBConfig()
+        self.es_config = ElasticsearchDBConfig(es_url="http://mock-url.net")
         self.vector_dim = 384
 
+    def test_init_without_url(self):
+        # Make sure it's not loaded from env
+        try:
+            del os.environ["ELASTICSEARCH_URL"]
+        except KeyError:
+            pass
+        # Test if an exception is raised when an invalid es_config is provided
+        with self.assertRaises(AttributeError):
+            ElasticsearchDB()
+
     def test_init_with_invalid_es_config(self):
         # Test if an exception is raised when an invalid es_config is provided
-        with self.assertRaises(ValueError):
-            ElasticsearchDB(es_config=None)
-
-    def test_init_with_invalid_vector_dim(self):
-        # Test if an exception is raised when an invalid vector_dim is provided
-        embedder = BaseEmbedder()
-        embedder.set_vector_dimension(None)
-        with self.assertRaises(ValueError):
-            ElasticsearchDB(es_config=self.es_config)
-
-    def test_init_with_invalid_collection_name(self):
-        # Test if an exception is raised when an invalid collection_name is provided
-        self.es_config.collection_name = None
-        with self.assertRaises(ValueError):
-            ElasticsearchDB(es_config=self.es_config)
+        with self.assertRaises(TypeError):
+            ElasticsearchDB(es_config={"ES_URL": "some_url", "valid es_config": False})