From 0c2653ccf5c2a0067aeda7ca1837920a52ff40b4 Mon Sep 17 00:00:00 2001 From: cachho Date: Fri, 7 Jul 2023 11:06:43 +0200 Subject: [PATCH] fix: embedding function config (#175) --- embedchain/embedchain.py | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/embedchain/embedchain.py b/embedchain/embedchain.py index d3cf0ae4..cc5e62de 100644 --- a/embedchain/embedchain.py +++ b/embedchain/embedchain.py @@ -364,15 +364,14 @@ class OpenSourceApp(EmbedChain): :param config: InitConfig instance to load as configuration. Optional. `ef` defaults to open source. """ print("Loading open source embedding model. This may take some time...") - if not config or not config.ef: - if config is None: - config = InitConfig( - ef = embedding_functions.SentenceTransformerEmbeddingFunction( - model_name="all-MiniLM-L6-v2" - ) + if not config: + config = InitConfig( + ef = embedding_functions.SentenceTransformerEmbeddingFunction( + model_name="all-MiniLM-L6-v2" ) - else: - config._set_embedding_function( + ) + elif not config.ef: + config._set_embedding_function( embedding_functions.SentenceTransformerEmbeddingFunction( model_name="all-MiniLM-L6-v2" ))